Conversation
Configs with (effectively) default image io settings will be switched to use PNJ. Otherwise, they will continue to use BufferedImage. Some basic testing shows that PNJ gives compression near the max setting for BufferedImage while taking less time. The following results are for rendering the same map twice in a row (after a warmup run) averaged over a couple of runs (time), and for the whole tiles directory for the dimension (size). Time is what was spent in `MapImage#save` on the image io thread as measured by spark (async profiler). PNJ : 724K in 1400ms BufferedImage compress-images=enabled, value=1 : 712K in 2300ms BufferedImage compress-images=disabled : 804K in 950ms
This comment has been minimized.
This comment has been minimized.
Repository owner
locked and limited conversation to collaborators
Jul 23, 2025
Repository owner
unlocked this conversation
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configs with (effectively) default image io settings will be switched to use PNJ. Otherwise, they will continue to use BufferedImage. Acceptable values for the backend option are
pnjandbufferedimage.Some basic testing shows that PNJ gives compression near the max setting for BufferedImage while taking less time.
The following results are for rendering the same map twice in a row (after a warmup run) averaged over a couple of runs (time), and for the whole tiles directory for the dimension (size). Time is what was spent in
MapImage#saveon the image io thread as measured by spark (async profiler).Questions to answer before merging:
MapImage#savemethod (which includes encode and decode).